Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement accepting dual-funded channels without contributing #3137

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Implement accepting dual-funded channels without contributing #3137

wants to merge 22 commits into from
+2,051 −411

Commits on Nov 13, 2024

  1. Add dual-funding spec links

    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    8acb178 View commit details
    Browse the repository at this point in the history

  2. Remove dual_funding cfg attributes 

    We'll only gate public API related to contributing toward an inbound or opening
a dual funded channel.
    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    06d08c7 View commit details
    Browse the repository at this point in the history

  3. Add interactive tx constructor to all V2-related channel structs 

    Here we add the `interactive_tx_constructor` field to the `Channel`,
`OutboundV2Channel`, and `InboundV2Channel` structs.
    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    790d65c View commit details
    Browse the repository at this point in the history

  4. Remove unused Channel::dual_funding_channel_context 

    For now this is unneeded as we do not provide any inputs as channel
acceptor and we do not allow creating outbound channels yet. It will
be re-added when that functionality is introduced.
    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f4578ff View commit details
    Browse the repository at this point in the history

  5. Add features in InteractiveTxConstructor requried for V2 chan accept 

    1. InteractiveTxConstructorArgs is introduced to act as a single, more
   readable input to InteractiveTxConstructor::new().
2. Various documentation updates.
    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5f90ad4 View commit details
    Browse the repository at this point in the history

  6. Implement support for accepting V2 channels

    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    e67ce54 View commit details
    Browse the repository at this point in the history

  7. f let user provide total witness weight for inputs for accurate fee c… 

    …alculation
    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    be8e1c6 View commit details
    Browse the repository at this point in the history

  8. Introduce InteractiveTxSigningSession for signing interactively const… 

    …ructed txs
    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    fe7ad62 View commit details
    Browse the repository at this point in the history

  9. Handle initial commitment_signed for V2 channels

    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d4806ae View commit details
    Browse the repository at this point in the history

  10. f remove unused their_funding_satoshis field

    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    72a4745 View commit details
    Browse the repository at this point in the history

  11. f move get_initial_commitment_signed to ChannelContext method & clean… 

    … up funding_tx_constructed
    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5a569b7 View commit details
    Browse the repository at this point in the history

  12. f set ChannelContext::funding_transaction in funding_tx_constructed

    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    338fb01 View commit details
    Browse the repository at this point in the history

  13. Handle re-establishment next_funding_txid

    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5d60495 View commit details
    Browse the repository at this point in the history

  14. f set and clear next_funding_txid in channel.rs directly

    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    fabe32d View commit details
    Browse the repository at this point in the history

  15. f replace side-effect map with matches

    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    1479f87 View commit details
    Browse the repository at this point in the history

  16. f wip: handling async monitor persist and checks for tx_signatures

    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    1c6f097 View commit details
    Browse the repository at this point in the history

  17. f get tx_signatures ready if we're up first upon receiving initial co… 

    …mmitment_signed
    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    51531fb View commit details
    Browse the repository at this point in the history

  18. Add option_dual_fund feature

    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3d4e876 View commit details
    Browse the repository at this point in the history

  19. Temporarily allow some unused dual-funding code

    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c63f12b View commit details
    Browse the repository at this point in the history

  20. Add manual testing for accepting dual-funded channels

    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    97b532d View commit details
    Browse the repository at this point in the history

  21. Fix docs to indicate OpenChannelRequest is NOT persisted across restarts

    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c55b1d5 View commit details
    Browse the repository at this point in the history

  22. Remove unused muts in channel tests

    @dunxen
    dunxen committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    908df1e View commit details
    Browse the repository at this point in the history