Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Channel force-close with pending blocked monitors blocking another channel #2168

Closed
TheBlueMatt opened this issue Apr 7, 2023 · 2 comments
Assignees
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

Now (post-#2167 and its followup) that a monitor can block another channel from making progress we need to make sure that a channel force-closing while blocking another monitor (implying it could leave the other monitor blocked if we restart without completing the required monitors which are gone since the channel was deleted) doen't hang us.

@TheBlueMatt
Copy link
Collaborator Author

Also #2167 (comment)

@TheBlueMatt
Copy link
Collaborator Author

Re: #2167 (comment) we should be good as of #2167, I pushed the requested comment in #2391.

Gonna go ahead and close this as completed in #2167 - while its possible there's some edge cases missed, the tests in #2169 show at least the basic cases here were fixed though I'm sill worried a bit about the completion-notification pipeline which I want to rewrite in 117 as #2389.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant