Break ClosureReason::CommitmentTxConfirmed Up Somewhat

[TheBlueMatt]

If an HTLC times out and we close a channel from the ChannelMonitor, we currently mark the ClosureReason as CommitmentTxConfirmed, even though the commitment tx has not yet confirmed, not to mention it was us who closed the channel! From a cursory glance, the fix is trivial - just interpret (and maybe rename) MonitorEvent::CommitmentTxConfirmed to mean "we force-closed" and then we can think about adding more detail, but I think its literally always due to HTLC timeouts.

[colinh80]

Hi, is the idea to decide on a more fitting name and replace all uses of CommitmentTxConfirmed with the new name? As well as reinterpret the note on CommitmentTxConfirmed in the Monitor Event enum?

I'm also curious about MonitorEvent::FundingTimedOut. I don't see it used anywhere but it seems more appropriate for HTLC time outs

[TheBlueMatt]

Hi, is the idea to decide on a more fitting name and replace all uses of CommitmentTxConfirmed with the new name?

No, the existing uses of it are fine, its only the MonitorEvent::CommitmentTxConfirmed case that needs changing.

I'm also curious about MonitorEvent::FundingTimedOut. I don't see it used anywhere but it seems more appropriate for HTLC time outs

No, this is about the funding not confirming in enough time, not us force-closing. Currently ProcessingError is what we use for "we force-closed".

[Mirebella]

Is this still open? Looks like a96e2fe commit and #2887 in "assesment against linked issues" section might have already addressed it.

[TheBlueMatt]

Yep, I think this is fixed, thanks!