Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vss-client upgrade to 0.3.x #357

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Conversation

G8XSU
Copy link
Contributor

@G8XSU G8XSU commented Sep 7, 2024

  • Vss-client upgrade to 0.3.x
  • Fix vss war name for vss-server binary in CI.

Depends on lightningdevkit/vss-rust-client#35 and lightningdevkit/vss-server#32

@G8XSU
Copy link
Contributor Author

G8XSU commented Sep 11, 2024

Ready for review
Since dependent PRs lightningdevkit/vss-rust-client#35 and lightningdevkit/vss-server#32
are merged now.

@G8XSU G8XSU requested a review from tnull September 11, 2024 19:29
@tnull
Copy link
Collaborator

tnull commented Sep 12, 2024

Ready for review Since dependent PRs lightningdevkit/vss-rust-client#35 and lightningdevkit/vss-server#32 are merged now.

Seems this still fails to build, presumably since the patched version hasn't actually been released yet?

@tnull tnull mentioned this pull request Sep 12, 2024
@G8XSU
Copy link
Contributor Author

G8XSU commented Sep 12, 2024

Seems this still fails to build, presumably since the patched version hasn't actually been released yet?

Published vss-client last night, but CI was still failing.
Pushed another commit to fix lightning-liquidity to =alpha4 until alpha5 upgrade PR lands.

Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnull tnull merged commit 1a6a2ca into lightningdevkit:main Sep 13, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants