Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cc msrv #324

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Fix cc msrv #324

merged 1 commit into from
Jul 12, 2024

Conversation

jbesraa
Copy link
Contributor

@jbesraa jbesraa commented Jul 10, 2024

No description provided.

@jbesraa jbesraa force-pushed the 2024-07-10-fix-msrv branch 2 times, most recently from b838f8c to 2271419 Compare July 10, 2024 11:14
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Currently still holding off on this until it's clear whether cc will reduce MSRV again.

Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go ahead with this. One nit though.

@@ -49,6 +49,7 @@ jobs:
cargo update -p proptest --precise "1.2.0" --verbose # proptest 1.3.0 requires rustc 1.64.0
cargo update -p regex --precise "1.9.6" --verbose # regex 1.10.0 requires rustc 1.65.0
cargo update -p home --precise "0.5.5" --verbose # home v0.5.9 requires rustc 1.70 or newer
cargo update -p cc --precise "1.0.105" --verbose # cc 1.1.0 requires rustc 1.67 or newer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It's actually already 1.0.106 that requires 1.67.

Suggested change
cargo update -p cc --precise "1.0.105" --verbose # cc 1.1.0 requires rustc 1.67 or newer
cargo update -p cc --precise "1.0.105" --verbose # cc 1.0.106 requires rustc 1.67 or newer

@tnull tnull merged commit 403c137 into lightningdevkit:main Jul 12, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants