WIP: Backport KVStore changes
#159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. as we don't require all that logic anymore now that we don't return an `FilesystemWriter` anymore etc.
This will be mandatory on the upstreamed trait anyways and is useful to make it easiert to compare returned values.
tnull
force-pushed
the
2023-08-kvstore-updates
branch
from
a695c1f
to
e1d081c
Compare
.. which asserts that all `KVStore` implementations operatate synchronously, i.e., yield identical results given the same inputs.
tnull
force-pushed
the
2023-08-kvstore-updates
branch
from
e1d081c
to
76d2f03
Compare
|
Closing this as the changes will need to happen as part of #151. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR encompasses fixes and minor changes that were raised during upstreaming the
KVStore.