Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing channel_config argument in README example for connect_open_channel #136

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

AustinKelsay
Copy link
Contributor

Add missing channel_config argument in README example for connect_open_channel to avoid this error:

----- an argument of type `std::option::Option<ChannelConfig>` is missing

connect_open_channel:

pub fn connect_open_channel(&**self**, node_id: PublicKey, address: NetAddress, channel_amount_sats: u64, push_to_counterparty_msat: Option<u64>, channel_config: Option<ChannelConfig>, announce_channel: bool) -> Result<(), Error>

Add missing channel_config argument in README example for connect_open_channel

```pub fn connect_open_channel(&**self**, node_id: PublicKey, address: NetAddress, channel_amount_sats: u64, push_to_counterparty_msat: Option<u64>, channel_config: Option<ChannelConfig>, announce_channel: bool) -> Result<(), Error>```
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thank you, good catch!

@tnull tnull merged commit 3c7dac9 into lightningdevkit:main Jul 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants