Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Partially) Revert BDK regtest workaround #359

Closed
tnull opened this issue Sep 12, 2024 · 1 comment
Closed

(Partially) Revert BDK regtest workaround #359

tnull opened this issue Sep 12, 2024 · 1 comment
Milestone

Comments

@tnull
Copy link
Collaborator

tnull commented Sep 12, 2024

In #358 we introduced a workaround for a reachable panic in BDK's chain syncing logic that would be triggered when we start syncing the node while on tip height 0, which would be the case for our previous regtest setup.

While splitting premine and distribute_funds is fine for the most part, in some test cases we are now required to premine where we previously didn't (which takes additional CI time). We should therefore at least partially revert the workaround commit as soon as BDK shipped the fix (bitcoindevkit/bdk#1601) and we upgraded to the next beta release (which we should do before our next release).

@tnull tnull added this to the 0.4 milestone Sep 12, 2024
This was referenced Sep 12, 2024
@tnull
Copy link
Collaborator Author

tnull commented Sep 16, 2024

Dropped the workaround in #358 already.

@tnull tnull closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant