withdrawals: return amount as little-endian #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
changed the title
This was referenced Sep 5, 2024
mkalinin
reviewed
Sep 9, 2024
| push 52 ;; [52, record_offset, pk2_am, i, ..] | ||
| add ;; [record_offset+52, pk2_am, i, ..] | ||
| mstore ;; [i, ..] | ||
| ;; Extract pk2 from pk2_am. |
There was a problem hiding this comment.
Could we mstore pk2_am and then just overwrite the last 8 bytes of am with little endian? This would save a few op calls
There was a problem hiding this comment.
Yeah, this step could be avoided. But removing would only save three instructions, and I think it's a bit safer to mask it explicitly.
There was a problem hiding this comment.
right, i am more in favour of less instructions than saving the cost. Fine with leaving it as is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the return data encoding SSZ-compatible.