Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of inline asm #337

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Fix handling of inline asm #337

merged 4 commits into from
Apr 29, 2024

Conversation

frabert
Copy link
Collaborator

@frabert frabert commented Apr 29, 2024

No description provided.

Copy link

See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/8881118286

fizzbuzz.bc

typedefs_of_typedefs.bc

switch_loop.bc

func_cond_zero_arg.bc

fcmp.bc

conflicting_names.bc

struct.bc

issue_183_literal_structs.bc

zeroinit.bc

issue_127_uint128_t_lit.bc

struct_swap.bc

global_using_function_decl.bc

issue_333_inline_asm.bc

init_list.bc

ret0.bc

goto_loop.bc

trunc.bc

bitops.bc

cast.bc

nullptr.bc

nested_struct.bc

array_swap.bc

binops.bc

bitmask.bc

loop.bc

float.bc

reg_test_structure_fields.bc

vectors.bc

funcptr.bc

inttoptr.bc

short.bc

issue_4.bc

conflicting_global.bc

issue_123_uint128_t.bc

fizzbuzz_stateful.bc

issue_94_strncmp.bc

bool.bc

zext.bc

byval_struct.bc

nested_while.bc

--- /dev/fd/63	2024-04-29 15:23:44.076364505 +0000
+++ /dev/fd/62	2024-04-29 15:23:44.076364505 +0000
@@ -25,7 +25,7 @@
                 printf("loop2 x: %d\n", var1);
             }
     }
-    if (((int)var1 >= 20 || (int)var1 <= 10) && (int)var1 >= 20) {
+    if ((int)var1 >= 20 && ((int)var1 >= 20 || (int)var1 <= 10)) {
         return var0;
     }
 }

func_cond_two_arg.bc

assert.bc

switch.bc

branch.bc

template_parameter_pack.bc

byval_tail_nogep.ll

byval_tail_gep.ll

Copy link

See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/8881264011

fizzbuzz.bc

typedefs_of_typedefs.bc

switch_loop.bc

func_cond_zero_arg.bc

fcmp.bc

conflicting_names.bc

struct.bc

issue_183_literal_structs.bc

zeroinit.bc

issue_127_uint128_t_lit.bc

struct_swap.bc

global_using_function_decl.bc

issue_333_inline_asm.bc

--- /dev/fd/63	2024-04-29 15:34:11.396253906 +0000
+++ /dev/fd/62	2024-04-29 15:34:11.396253906 +0000
@@ -0,0 +1,8 @@
+void a(void *arg0);
+void asm_1(void);
+void a(void *arg0) {
+    void *var0;
+    var0 = arg0;
+    asm_1();
+    return;
+}

init_list.bc

ret0.bc

goto_loop.bc

trunc.bc

bitops.bc

cast.bc

nullptr.bc

nested_struct.bc

array_swap.bc

binops.bc

bitmask.bc

loop.bc

float.bc

reg_test_structure_fields.bc

vectors.bc

funcptr.bc

inttoptr.bc

short.bc

issue_4.bc

conflicting_global.bc

issue_123_uint128_t.bc

fizzbuzz_stateful.bc

issue_94_strncmp.bc

bool.bc

zext.bc

byval_struct.bc

nested_while.bc

--- /dev/fd/63	2024-04-29 15:34:14.180250355 +0000
+++ /dev/fd/62	2024-04-29 15:34:14.180250355 +0000
@@ -25,7 +25,7 @@
                 printf("loop2 x: %d\n", var1);
             }
     }
-    if (((int)var1 >= 20 || (int)var1 <= 10) && (int)var1 >= 20) {
+    if ((int)var1 >= 20 && ((int)var1 >= 20 || (int)var1 <= 10)) {
         return var0;
     }
 }

func_cond_two_arg.bc

assert.bc

switch.bc

branch.bc

template_parameter_pack.bc

byval_tail_nogep.ll

byval_tail_gep.ll

Copy link

See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/8881448413

fizzbuzz.bc

typedefs_of_typedefs.bc

switch_loop.bc

func_cond_zero_arg.bc

fcmp.bc

conflicting_names.bc

struct.bc

issue_183_literal_structs.bc

zeroinit.bc

issue_127_uint128_t_lit.bc

struct_swap.bc

global_using_function_decl.bc

issue_333_inline_asm.bc

--- /dev/fd/63	2024-04-29 15:51:29.504490014 +0000
+++ /dev/fd/62	2024-04-29 15:51:29.504490014 +0000
@@ -0,0 +1,10 @@
+int main(int arg0, char **arg1);
+void asm_1(void);
+int main(int arg0, char **arg1) {
+    unsigned int var0;
+    void *var1;
+    var0 = arg0;
+    var1 = arg1;
+    asm_1();
+    return 0U;
+}

init_list.bc

ret0.bc

goto_loop.bc

trunc.bc

bitops.bc

cast.bc

nullptr.bc

nested_struct.bc

array_swap.bc

binops.bc

bitmask.bc

loop.bc

float.bc

reg_test_structure_fields.bc

vectors.bc

funcptr.bc

inttoptr.bc

short.bc

issue_4.bc

conflicting_global.bc

issue_123_uint128_t.bc

fizzbuzz_stateful.bc

issue_94_strncmp.bc

bool.bc

zext.bc

byval_struct.bc

nested_while.bc

--- /dev/fd/63	2024-04-29 15:51:32.284467234 +0000
+++ /dev/fd/62	2024-04-29 15:51:32.284467234 +0000
@@ -25,7 +25,7 @@
                 printf("loop2 x: %d\n", var1);
             }
     }
-    if ((int)var1 >= 20 && ((int)var1 >= 20 || (int)var1 <= 10)) {
+    if (((int)var1 >= 20 || (int)var1 <= 10) && (int)var1 >= 20) {
         return var0;
     }
 }

func_cond_two_arg.bc

assert.bc

switch.bc

branch.bc

template_parameter_pack.bc

byval_tail_nogep.ll

byval_tail_gep.ll

Copy link

See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/8881657190

fizzbuzz.bc

typedefs_of_typedefs.bc

switch_loop.bc

func_cond_zero_arg.bc

fcmp.bc

conflicting_names.bc

struct.bc

issue_183_literal_structs.bc

zeroinit.bc

issue_127_uint128_t_lit.bc

struct_swap.bc

global_using_function_decl.bc

init_list.bc

ret0.bc

goto_loop.bc

trunc.bc

bitops.bc

cast.bc

nullptr.bc

nested_struct.bc

array_swap.bc

binops.bc

bitmask.bc

loop.bc

float.bc

reg_test_structure_fields.bc

vectors.bc

funcptr.bc

inttoptr.bc

short.bc

issue_4.bc

conflicting_global.bc

issue_123_uint128_t.bc

fizzbuzz_stateful.bc

issue_94_strncmp.bc

bool.bc

zext.bc

byval_struct.bc

nested_while.bc

--- /dev/fd/63	2024-04-29 16:03:03.255740562 +0000
+++ /dev/fd/62	2024-04-29 16:03:03.255740562 +0000
@@ -25,7 +25,7 @@
                 printf("loop2 x: %d\n", var1);
             }
     }
-    if ((int)var1 >= 20 && ((int)var1 >= 20 || (int)var1 <= 10)) {
+    if (((int)var1 >= 20 || (int)var1 <= 10) && (int)var1 >= 20) {
         return var0;
     }
 }

func_cond_two_arg.bc

assert.bc

switch.bc

branch.bc

template_parameter_pack.bc

byval_tail_nogep.ll

byval_tail_gep.ll

issue_335_z3_ite.ll

@frabert frabert marked this pull request as ready for review April 29, 2024 16:16
@frabert frabert requested a review from surovic April 29, 2024 16:16
@surovic surovic merged commit 22f65d6 into master Apr 29, 2024
6 checks passed
@surovic surovic deleted the frabert/fix-333 branch April 29, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants