Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare results of expression simplifier on vs. off #213

Open
artemdinaburg opened this issue Jan 10, 2022 · 0 comments
Open

Compare results of expression simplifier on vs. off #213

artemdinaburg opened this issue Jan 10, 2022 · 0 comments

Comments

@artemdinaburg
Copy link
Contributor

We now handle many expression simplifications at the anvill level.

Do we still need an expression simplifier, since it occasionally fails?

Lets do the following:

  1. Make the expression simplifier on or off via a flag (--simplify-expressions)
  2. Run on Angha with --simplify-expressions
  3. Run on Angha w/o --simplify-expressions
  4. Do a diff of the output C and make a decision whether to default it to on or off, or to limit scope in some way to avoid the error conditions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant