Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New lift approach #47

Merged
merged 7 commits into from
Oct 15, 2024
Merged

New lift approach #47

merged 7 commits into from
Oct 15, 2024

Conversation

pgoodman
Copy link
Contributor

@pgoodman pgoodman commented Oct 11, 2024 •
edited
Loading

  • Migrates Akshay high p-code lifting support to the old script.
  • Canonicalizes both the headless and gui codepaths to operate on lists of functions.
  • Saturates a set of functions to lift, where the initial input set is treated as those for which we want definitions (i.e. high p-code)
  • Starts doing p-code operation-specific lifting in the JSON representation. E.g. CBRANCH and CALL. This is important to eventually discover (and thus saturate) all referenced functions and global symbols.

@pgoodman pgoodman requested a review from xlauko as a code owner October 11, 2024 17:12
@pgoodman pgoodman requested review from kumarak and removed request for xlauko October 11, 2024 17:12
@pgoodman pgoodman changed the title Lift types New lift approach Oct 11, 2024
@xlauko
Copy link
Collaborator

xlauko commented Oct 15, 2024

@pgoodman can you clean up commit messages, please. I want to use change-logs for quarterly reports.

pgoodman and others added 7 commits October 15, 2024 16:15
@pgoodman @kumarak
ghidra: Refactoring high p-code stuff into the base script.
a8bc88e
@pgoodman @kumarak
ghidra: Saturate and bring in directly referenced functions for non-d…
3ac9006 
…efinition lifting. Drilling in on more specific handling of p-code operations.
@pgoodman @kumarak
ghidra: Resolve calls to indirects through memory
80f460b
@pgoodman @kumarak
ghidra: Minor refactor of label generation.
17edd08
@kumarak
test: fix ci failure due to unit tests
75044d2
@pgoodman @kumarak
ghidra: Change the pcode list in basic blocks into two things: an ope…
2ddb924 
…rations object, keyed by operation labels, and an ordered_operations list, containing just labels. The idea will be so that we can directly reference uniques via their operation labels, and thus use operation labels as the names of the actual operations in mlir
@pgoodman @kumarak
ghidra: Get rid of first_operation. It is redundant w.r.t. ordered_op…
0d6c9b2 
…erations.
@kumarak kumarak merged commit 1b21b57 into main Oct 15, 2024
5 checks passed
@kumarak kumarak deleted the lift_types branch October 15, 2024 16:36
@xlauko xlauko added the ghidra label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumarak kumarak kumarak approved these changes

Assignees
No one assigned
Labels
ghidra
Projects
None yet
Milestone
1.B P-Code MLIR Dialect and Translation
Development

Successfully merging this pull request may close these issues.
3 participants
@pgoodman @xlauko @kumarak