Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to explicitly setting CMake toolchain file #43

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Move to explicitly setting CMake toolchain file #43

merged 5 commits into from
Jan 4, 2024

Conversation

Ninja3047
Copy link
Contributor

No description provided.

ekilmer
ekilmer reviewed Jan 2, 2024
View reviewed changes
CMakePresets.json Outdated Show resolved Hide resolved
ekilmer
ekilmer approved these changes Jan 2, 2024
View reviewed changes
Copy link

@ekilmer ekilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

ekilmer
ekilmer requested changes Jan 2, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Ninja3047 Ninja3047 added enhancement New feature or request cmake labels Jan 3, 2024
@xlauko xlauko merged commit aaf9a3a into main Jan 4, 2024
2 checks passed
@xlauko xlauko deleted the will/cmake-toolchain-file branch January 4, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekilmer ekilmer ekilmer approved these changes

@xlauko xlauko xlauko approved these changes

Assignees
No one assigned
Labels
cmake enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ninja3047 @ekilmer @xlauko