Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close #73 #74

Merged
merged 1 commit into from
Aug 2, 2023
Merged

close #73 #74

merged 1 commit into from
Aug 2, 2023

Conversation

jobrachem
Copy link
Contributor

Simply replace the three remaining uses of jnp.DeviceArray with jax.Array to establish compatibility with Jax v0.4.14. See #73

@jobrachem jobrachem added the bug Something isn't working label Jul 29, 2023
@jobrachem jobrachem requested a review from hriebl July 29, 2023 18:45
@jobrachem jobrachem self-assigned this Jul 29, 2023
@jobrachem
Copy link
Contributor Author

@hriebl would you review?

hriebl
hriebl approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@hriebl hriebl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that jax.Array is available since v0.4.1, which is the current lower bound of our dependency, so we're good to go!

@hriebl hriebl merged commit 17d09e6 into main Aug 2, 2023
3 checks passed
@hriebl hriebl deleted the remove-devicearray branch August 2, 2023 09:26
@GianmarcoCallegher
Copy link
Contributor

If one installs liesel from pip, they will get the same error. I guess we have to release a new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hriebl hriebl hriebl approved these changes

Assignees

@jobrachem jobrachem

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jobrachem @GianmarcoCallegher @hriebl