GPU: Add SDL_CalculateGPUTextureFormatSize #11146
Merged
+34
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flibitijibibo
approved these changes
Oct 10, 2024
slouken
reviewed
Oct 10, 2024
slouken
reviewed
Oct 10, 2024
slouken
reviewed
Oct 10, 2024
|
I'm fine with this. It looks like BytesPerImage needs to be replaced with a call to this function? |
slime73
reviewed
Oct 10, 2024
thatcosmonaut
force-pushed
the
texture_size
branch
2 times, most recently
from
51a381a
to
d950363
Compare
sezero
reviewed
Oct 10, 2024
Update include/SDL3/SDL_gpu.h Co-authored-by: Sam Lantinga <[email protected]>
thatcosmonaut
force-pushed
the
texture_size
branch
from
f5e8839
to
1e12805
Compare
|
Addressed all the comments, let me know if there's anything else. |
slouken
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly common client need and it's annoyingly nuanced to implement, so we should expose it.