Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Backend generate() res TokenStream to String #19

Merged
merged 2 commits into from
May 2, 2024
Merged

fix: Backend generate() res TokenStream to String #19

merged 2 commits into from
May 2, 2024

Conversation

v0-e
Copy link
Contributor

@v0-e v0-e commented Apr 30, 2024 •
edited
Loading

Makes Backend generate() return a String instead of a TokenStream so Backend can be used in non-Rust bindings.
Possible fix for #18.

6d7a
6d7a requested changes May 2, 2024
View reviewed changes
Copy link
Member

@6d7a 6d7a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

rasn-compiler/src/generator/rasn/mod.rs Outdated Show resolved Hide resolved
@v0-e v0-e force-pushed the backend-generate-string branch from d319a08 to 216616e Compare May 2, 2024 08:15
@6d7a
Copy link
Member

6d7a commented May 2, 2024

Great! LGTM.

@6d7a 6d7a merged commit 887e1a6 into librasn:main May 2, 2024
1 check passed
6d7a added a commit that referenced this pull request May 7, 2024
@6d7a
Merge pull request #19 from v0-e/backend-generate-string
d0fd607 
fix: Backend generate() res TokenStream to String
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6d7a 6d7a 6d7a requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v0-e @6d7a