From 4bd0f9992f63cdc2f679c326eccf3f551ebb53b3 Mon Sep 17 00:00:00 2001 From: Marco Munizaga Date: Fri, 14 Jul 2023 11:48:08 -0700 Subject: [PATCH] Revert "Install playwright in the base image so it is cached (#226)" (#231) * Revert "Install playwright in the base image so it is cached (#226)" This reverts commit d21d042ddd039b8e8e1f6c007a9eb169a3daf5fd. * Add comment --- multidim-interop/impl/js/v0.45/BrowserDockerfile | 4 ++++ multidim-interop/impl/js/v0.45/Dockerfile | 1 - 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/multidim-interop/impl/js/v0.45/BrowserDockerfile b/multidim-interop/impl/js/v0.45/BrowserDockerfile index 8a84c1599..218f5c159 100644 --- a/multidim-interop/impl/js/v0.45/BrowserDockerfile +++ b/multidim-interop/impl/js/v0.45/BrowserDockerfile @@ -11,6 +11,10 @@ FROM mcr.microsoft.com/playwright COPY --from=js-libp2p-base /app/ /app/ WORKDIR /app/interop +# We install browsers here instead of the cached version so that we use the latest browsers at run time. +# Ideally this would also be pinned, but playwright controls this, so there isn't much we can do about it. +# By installing here, we avoid installing it at test time. +RUN ./node_modules/.bin/playwright install ARG BROWSER=chromium # Options: chromium, firefox, webkit ENV BROWSER=$BROWSER diff --git a/multidim-interop/impl/js/v0.45/Dockerfile b/multidim-interop/impl/js/v0.45/Dockerfile index 1d49d6c73..40e67d678 100644 --- a/multidim-interop/impl/js/v0.45/Dockerfile +++ b/multidim-interop/impl/js/v0.45/Dockerfile @@ -7,6 +7,5 @@ RUN npm i && npm run build WORKDIR /app/interop RUN npm i && npm run build -RUN ./node_modules/.bin/playwright install ENTRYPOINT [ "npm", "test", "--", "--build", "false", "--types", "false", "-t", "node" ]