Skip to content
This repository has been archived by the owner on Aug 23, 2019. It is now read-only.

Add private network support #266

Merged
merged 2 commits into from
Jul 19, 2018
Merged

Add private network support #266

merged 2 commits into from
Jul 19, 2018

Conversation

jacobheun
Copy link
Contributor

This adds support for the usage of private networking protectors.

Protectors can be specified via configuration or by setting the protector directly. Tests have been added using the unreleased libp2p-pnet, libp2p-pnet#1 as a working example.

You can see a demo of this working at https://youtu.be/fObld4alGag?t=47.

relates to libp2p/js-libp2p-pnet#1

package.json Outdated
@@ -43,6 +43,7 @@
"dirty-chai": "^2.0.1",
"gulp": "^3.9.1",
"libp2p-mplex": "~0.7.0",
"libp2p-pnet": "github:libp2p/js-libp2p-pnet#feat/initial",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be released?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it can, I am just waiting for a thumbs up on libp2p/js-libp2p-pnet#1

Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far.

fix: update protector.protect usage
chore: fix linting and update deps
test: add secio to pnet tests
docs: add private network info the readme
test: add skipped test back in and update it
@jacobheun jacobheun merged commit b6600da into master Jul 19, 2018
@ghost ghost removed the in progress label Jul 19, 2018
@jacobheun jacobheun deleted the feat/priv-net branch July 19, 2018 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants