Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the testsuite does not leave artifacts behind #324

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

baldurmen
Copy link

Hello!

While working on the Debian package for pykeepass, I found out when the testsuite is ran, db_dump.xml is left behind in the CWD.

This commit makes so that it runs cleanly.

Cheers,

@Evidlo
Copy link
Member

Evidlo commented Oct 25, 2022

Maybe it would be better just to use tempfile.TemporaryFile directly?

@baldurmen
Copy link
Author

It could be done and I certainly wouldn't be against it, but this is really a drive-by patch. It was simple enough that I submitted a patch instead of opening a bug report.

I'm not sure I have the motivation (even if it's a pretty simple change) to make extra changes though...

Bonus points: I've tested this patch and it works :)

Thank you for caring and for your work on this project though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants