Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FreeBSD support: #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rozhuk-im
Copy link

sshfs.c Outdated Show resolved Hide resolved
sshfs.c Outdated Show resolved Hide resolved
sshfs.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@Nikratio Nikratio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! As mentioned in the other comment, I think there may be a way to avoid the need for an optional workaround. Please let me know what you think.

uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Jun 5, 2020
- include posix_openpt() usage patch
- add workaround for readdir() issue: #211
- fix few warnings
- Add DOCS option
- remove gettext dep

Upstream patches:
libfuse/sshfs#212
libfuse/sshfs#211

PR:		246325
Submitted by:	[email protected]


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@538024 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Jun 5, 2020
- include posix_openpt() usage patch
- add workaround for readdir() issue: #211
- fix few warnings
- Add DOCS option
- remove gettext dep

Upstream patches:
libfuse/sshfs#212
libfuse/sshfs#211

PR:		246325
Submitted by:	[email protected]
Jehops pushed a commit to Jehops/freebsd-ports-legacy that referenced this pull request Jun 5, 2020
- include posix_openpt() usage patch
- add workaround for readdir() issue: #211
- fix few warnings
- Add DOCS option
- remove gettext dep

Upstream patches:
libfuse/sshfs#212
libfuse/sshfs#211

PR:		246325
Submitted by:	[email protected]


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@538024 35697150-7ecd-e111-bb59-0022644237b5
@Nikratio
Copy link
Contributor

Are you still interested in working on this? If not, I'll close the pull request in a few days.

@rozhuk-im
Copy link
Author

FreeBSD already take this into ports tree :)

How do you suggest to rework this?
Remove option and make this "workaround" persistent?

@Nikratio
Copy link
Contributor

I'm happy with most of the patch, but I don't understand the need for the readdir workaround. I'd much rather see it removed from the patch and discussed separately.

@Nikratio
Copy link
Contributor

Are you still interested in working on this? If not, I'll close this pull request for now.

@rozhuk-im rozhuk-im force-pushed the fbsd_fixes branch 2 times, most recently from df68941 to d2623b2 Compare June 11, 2022 03:08
- include posix_openpt() usage patch
- add workaround for readdir() issue: libfuse#211, libfuse#278
- fix few warnings
@kalvdans
Copy link
Contributor

Does pam_mount exist on FreeBSD? Otherwise I think it is better to disable the password_stdin flag.

@rozhuk-im
Copy link
Author

pam_mount

Yes: https://www.freshports.org/sysutils/pam_mount

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants