Skip to content
This repository has been archived by the owner on Apr 27, 2023. It is now read-only.

Ensure that we can do rolling updates/replicas #998

Closed
10 tasks done
erkannt opened this issue Jun 2, 2020 · 1 comment
Closed
10 tasks done

Ensure that we can do rolling updates/replicas #998

erkannt opened this issue Jun 2, 2020 · 1 comment
Assignees
Labels
Infrastructure General Infrastructure work
Milestone

Comments

@erkannt
Copy link
Contributor

erkannt commented Jun 2, 2020

If we want to have rolling updates/replicas of reviewer we need to ensure several things:

  • Multiple pods can use RDS/s3 simultaneously in a safe manner
  • File upload and progress state get handled by by same pod
  • Applications need to handle SIGTERM
  • Ensure you don’t end in bad state if SIGKILL or websocket connection gets terminated due to nginx config reload (see this article)

You can manage where traffic goes with

This ticket is result of discussion ticket #907

DoD:

  • connections to submission are sticky
  • submission pods are kept alive to handle existing connections during rollout
  • per app replica and disruptionbudget
  • ingress sends existing connections to old pod
  • grace-period can be set via values.yaml

I have successfully uploaded large files while performing a rollout. I haven't looked deeper if all subsystems are behaving as expected.

Tasks:

@erkannt
Copy link
Contributor Author

erkannt commented Aug 13, 2020

Blocked by #1310

@erkannt erkannt removed the blocked label Aug 17, 2020
@erkannt erkannt closed this as completed Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Infrastructure General Infrastructure work
Projects
None yet
Development

No branches or pull requests

1 participant