Not all files are deleted

[norisalsaadie]

There is no visual bug here.

When files are uploaded a database record is first created, the file is then uploaded to S3 / file storage and based on the success or failure of that upload the status is then updated.

There are instances in which files are successfully uploaded to S3 but the database record update is not successful. This means the DB record for those files is never updated to reflect a successful upload.

When deleting a submission, it might make sense to check all files regardless of status, and delete their associated S3 reference if one exists.