Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages vmtest steps into libbpf/ci actions #142

Closed
chantra opened this issue Sep 11, 2024 · 1 comment · Fixed by #143
Closed

packages vmtest steps into libbpf/ci actions #142

chantra opened this issue Sep 11, 2024 · 1 comment · Fixed by #143
Assignees

Comments

@chantra
Copy link
Collaborator

chantra commented Sep 11, 2024

We have some steps/actions in kernel-patches/vmtest that are not fully encapsulated:

.github/actions/veristat_baseline_compare/action.yml:      run: ./.github/scripts/compare-veristat-results.sh
.github/scripts/compare-veristat-results.sh:python3 ./.github/scripts/veristat_compare.py compare.csv
.github/scripts/tar-artifact.sh:    "scripts/"
.github/workflows/kernel-build.yml:          bash .github/scripts/get-commit-metadata.sh
.github/workflows/kernel-build.yml:          bash .github/scripts/prepare-incremental-builds.sh ${{ steps.get-commit-metadata.outputs.commit }}
.github/workflows/kernel-build.yml:          bash .github/scripts/tar-artifact.sh ${{ inputs.arch }} ${{ inputs.toolchain_full }}

Because the actions/workflow use local copies of the scripts, they can only be used by the kernel-patches/vmtest (or anything that copies the files locally). Running this from another repo would fail to find those scripts.

We should package those individual steps into libbpf/ci actions which we then can re-use from kernel-patches/vmtest and/or libbpf/libbpf.

@chantra
Copy link
Collaborator Author

chantra commented Sep 11, 2024

hint.

As part of #141 a bunch of the logic got copied into libbpf/ci already:

.github/scripts/tar-artifact.sh:    "scripts/"
.github/workflows/kernel-build.yml:          bash .github/scripts/get-commit-metadata.sh
.github/workflows/kernel-build.yml:          bash .github/scripts/prepare-incremental-builds.sh ${{ steps.get-commit-metadata.outputs.commit }}
.github/workflows/kernel-build.yml:          bash .github/scripts/tar-artifact.sh ${{ inputs.arch }} ${{ inputs.toolchain_full }} 1

so what we need to do here is to convert those steps into actions, and then change vmtests to use those.

Feel free to cut individual issues/PR for each of those actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants