Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten and rationalize command names. #648

Open
evoskuil opened this issue Oct 29, 2019 · 1 comment
Open

Shorten and rationalize command names. #648

evoskuil opened this issue Oct 29, 2019 · 1 comment
Assignees
Milestone

Comments

@evoskuil
Copy link
Member

evoskuil commented Oct 29, 2019

Rename

fetch-compact-filter-checkpoint-node
fetch-compact-filter-headers-node
fetch-compact-filters-node
match-neutrino-filter-address
match-neutrino-filter-script
send-tx-node
send-tx-p2p

to

get-filter-checkpoint
get-filter-headers
get-filters
match-neutrino-address
match-neutrino-script
put-tx
broadcast-tx

'fetch'/'send' imply libbitcoin server
'get'/'put' imply single p2p node
'broadcast' implies p2p network (multiple nodes)
'neutrino' implies neutrino compact filters
'filter' implies compact filter

Renames to put-tx and broadcast-tx will require compatibility shims.

@evoskuil evoskuil added this to the 4.0 milestone Oct 29, 2019
@evoskuil evoskuil self-assigned this Oct 29, 2019
@pmienk
Copy link
Member

pmienk commented Oct 30, 2019

If you haven't started I can take this. Am currently expanding server and client to support filter queries, I think the -node should stay to distinguish.

evoskuil added a commit that referenced this issue Nov 1, 2019
Add compact filter client-server protcol requests, address #648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants