Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NASA, Transport Species Data to ChemicalSpecies? #258

Open
pbauman opened this issue Jul 3, 2018 · 0 comments
Open

Move NASA, Transport Species Data to ChemicalSpecies? #258

pbauman opened this issue Jul 3, 2018 · 0 comments

Comments

@pbauman
Copy link
Member

pbauman commented Jul 3, 2018

In both XML and ChemKin formats, the NASA thermo data (coefficients) and transport data are listed by species. Perhaps it makes sense to cache those data (using existing Antioch objects) within the ChemicalSpecies? It would make parsing much easier (because it's done at the time when we parse the species data) and then deduction of the thermo type is easier (we just query the chemical species instead of trying to poke in the input file or make assumptions based on the file type).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant