Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add architecture ppc64le to travis build #255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zazzel
Copy link

@zazzel zazzel commented Dec 7, 2020

Hi,
I had added ppc64le support on Travis-ci and Its been success added and build. Kindly review and merge same.

Changes done are added ppc64le arch and exclude LUANAME=luajit-2.0 since its not supporting ppc64le Arch.

The Travis ci build logs can be verified from the link below.
https://travis-ci.com/github/zazzel/lgi/builds/206977452
Please have a look.

Thank you

Add architecture ppc64le to travis build
@psychon
Copy link
Collaborator

psychon commented Dec 7, 2020

Hi,

thanks a lot for this PR.

However, I have to ask: Sorry, but what is the motivation for this? For example, one could add a Travis build with a big endian architecture because big endian causes much problems / has much differences. Or a reason could be "there were a couple of times where problems for ppc64 slipped through / could have been caught by CI". Is there something like this? Or are you just adding this PR "because".

My main issue with Travis in recent times has been build time. It only runs 3(?) jobs in parallel.
Random data point:

@zazzel
Copy link
Author

zazzel commented Dec 9, 2020

Hi Team,
This PR adds CI support for the IBM Power Little Endian (ppc64le) architecture. The idea is to ensure that the builds on this architecture are continuously tested along with the Intel builds (amd64) as this is part of the ubuntu distro on that architecture as well and detecting (and fixing) any issues or failures early would help to ensure that we are always up to date.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants