Fix deprecations for SF6.3 #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix deprecation raised on Symfony 6.3: Method "Symfony\Component\Console\Command\Command::configure()" might add "void" as a native return type declaration in the future. Do the same in child class "Lexik\Bundle\TranslationBundle\Command\ImportTranslationsCommand" now to avoid errors or add an explicit @return annotation to suppress this message. Note that the "void" return type have been introduced in PHP 8.1 so it's in line with the constraint in composer.json.
raziel057
changed the title
bartmcleod
approved these changes
Aug 4, 2023
|
@raziel057 The tests fail |
I seen this. It's not related to those commits but related to changes in a new release of doctrine annotation. No auto build happened from long time on this bundle. |
|
I fixed the auto build, but apparently, since then it broke. We need to fix that, as passing unit tests are the only check apart from looking at the code and thinking it looks reasonable :-) So @raziel057 if you can fix the tests that would be great, otherwise I will need to find some time to do so |
|
I spent time to test and fix issues related to DEV environment to run the tests: #432 |
|
@bartmcleod Do you I need to do something else for integration of the change here? |
|
@raziel057 probably need to merge master back in |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deprecation raised on Symfony 6.3 related to missing "void" return type in configure methods of commands:
Method "Symfony\Component\Console\Command\Command::configure()" might add "void" as a native return type declaration in the future. Do the same in child class "Lexik\Bundle\TranslationBundle\Command\ImportTranslationsCommand" now to avoid errors or add an explicit @return annotation to suppress this message.
Method "Symfony\Component\Console\Command\Command::configure()" might add "void" as a native return type declaration in the future. Do the same in child class "Lexik\Bundle\TranslationBundle\Command\ExportTranslationsCommand" now to avoid errors or add an explicit @return annotation to suppress this message.
Method "Symfony\Component\HttpKernel\Bundle\Bundle::build()" might add "void" as a native return type declaration in the future. Do the same in child class "Lexik\Bundle\TranslationBundle\LexikTranslationBundle" now to avoid errors or add an explicit @return annotation to suppress this message.
Note that the "void" return type have been introduced in PHP 8.1 so it's in line with the constraint in composer.json.