Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atom properties #79

Open
yuanjames opened this issue Apr 1, 2020 · 3 comments
Open

Atom properties #79

yuanjames opened this issue Apr 1, 2020 · 3 comments

Comments

@yuanjames
Copy link

Hi,

I am trying to get atoms' property (e.g bonds, atomic_mass), but the error shows 'Atom' object has no attribute 'bonds'

import skchem
import rdkit.Chem

mol = skchem.Mol.from_smiles('CC(=O)Cl')
print(mol.atoms[0].bonds)

@lewisacidic
Copy link
Owner

Hi @yuanjames! Thanks for the issue. There is a new complete rewrite of scikit-chem (in fact there has been 3 complete rewrites...) coming soon. I wouldn't really like to try and debug my super old code, so I would suggest waiting for the new release - can't give an ETA as I'm quite busy atm, but I'll give you a ping once it's done.

@yuanjames
Copy link
Author

yuanjames commented Apr 2, 2020 via email

@jaimergp
Copy link

jaimergp commented Dec 2, 2020

@lewisacidic

There is a new complete rewrite of scikit-chem

This is so awesome! I just learnt about this library now and I got very excited about the API design and integrations with the scikit ecosystem. I know you deliberately didn't provide an ETA, but I was wondering if you'd be willing to share your efforts more openly in a PR or something? I am currently involved in developing some libraries with similar (complementary) scope and could provide some help if needed! Otherwise I might be implementing some stuff on those libraries when it could be synergized in yours... Let me know if you are open to consider such a collaboration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants