Rename OpenHAB MQTT to Home Assistant (openHAB) MQTT #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described by @davidgraeff openHAB is supporting Home Assistant MQTT convention, so C005 should have Home Assistant in name. Arguments: openHAB is following HA convention this will help new users (like me) to setup ESPEasy with Home Assisnant
|
Maybe you can also add some examples in the documentation for default MQTT topics for both? |
|
@TD-er I |
A backslash at the start of a MQTT topic is always good to remove. (and to report to the project that demands it) |
|
@TD-er backslashes removed :) |
davidgraeff
approved these changes
Jul 24, 2019
|
@davidgraeff thanks 🙂 |
|
@TD-er can You merge this? 🙂 |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described by @davidgraeff openHAB is supporting Home Assistant MQTT convention, so C005 should have Home Assistant in the name - #1314 (comment)
Arguments:
openHAB is following Home Assistant convention, not the other way (new version of openHAB is using Homie convention)
this will help new users (like me) to set up ESPEasy with Home Assistant