Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review nonNull, add documentation #45

Open
sjshuck opened this issue Mar 8, 2022 · 0 comments
Open

Review nonNull, add documentation #45

sjshuck opened this issue Mar 8, 2022 · 0 comments

Comments

@sjshuck
Copy link

sjshuck commented Mar 8, 2022

Pun intended. 🙂

I appreciate this warning about filtered. (I guess the reason the type is written as Optic' instead of Prism' is to discourage people from reviewing it?)

I'm sure there's a reason nonNull is an improper Prism' instead of an improper Traversal', I'm just not sure what the reason is. Maybe the fix is to document wherever optics laws are violated in the library, as lens tries to, not only here but

>>> let s = "-0" in over _Number id s == s
False

etc.

@sjshuck sjshuck changed the title Review nonNull Review nonNull, add documentation Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant