Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take advantage of the latest EDMCOverlay (installable) #151

Open
3 of 6 tasks
lekeno opened this issue May 2, 2018 · 10 comments
Open
3 of 6 tasks

Take advantage of the latest EDMCOverlay (installable) #151

lekeno opened this issue May 2, 2018 · 10 comments

Comments

@lekeno
Copy link
Owner

lekeno commented May 2, 2018

Instead of distributing a copy with EDR:

  • Update documentation to point folks to EDMCOverlay's MSI
  • Update EDR to take advantage of the canonical EDMCOverlay
  • Verify what happens when updating EDR (i.e. plugin specific EDMCOverlay present). Do things work?
  • Tell EDR users to upgrade EDMCOverlay if they still have the one that was included with EDR, keep things working though.
  • When EDMCOVerlay is missing, use EDR's status line to guide folks (e.g. message + link to latest release)
  • Needs an updated release for canonical EDMCOverlay (with the send_shape method).
@lekeno lekeno added this to the 0.8 milestone May 2, 2018
lekeno added a commit that referenced this issue May 3, 2018
See issue #151
This will need to wait for a point update that includes the send_shape method.
@lekeno
Copy link
Owner Author

lekeno commented May 4, 2018

Aiming at the next update to v0.8.x

@lekeno lekeno modified the milestones: 0.8, 0.8.2 May 6, 2018
lekeno added a commit that referenced this issue May 7, 2018
@lekeno lekeno modified the milestones: 0.8.2, 0.8.3 Jun 7, 2018
@lekeno
Copy link
Owner Author

lekeno commented Jun 7, 2018

There is some weird issue with the canonical overlay (seems to exit repeatedly and get started multiple times)

I also need a version with shape support in the python helper.

Hmm, maybe not ready for 0.8.2

@inorton
Copy link

inorton commented Jun 7, 2018

Hmm odd, the new build doesn't actually have any code changes. But occasionally directx or nvidia updates have made it unstable.

@lekeno
Copy link
Owner Author

lekeno commented Jun 11, 2018

EDMCOverlay exe found: [...]\AppData\Local\EDMarketConnector\plugins\EDMCOverlay\EDMCOverlay.exe...
EDMCOverlay is starting 

[...]\AppData\Local\EDMarketConnector\plugins\EDMCOverlay\EDMCOverlay.exe

error in ensure_service: [...]\AppData\Local\EDMarketConnector\plugins\EDMCOverlay\EDMCOverlay.exe exited"

Is the type of error I see frequently and repeatedly.
@inorton any idea?

@inorton
Copy link

inorton commented Jun 11, 2018

Can you find me your edmcoverlay.log file?

@lekeno lekeno modified the milestones: 0.8.3, 0.8.4 Jun 12, 2018
@lekeno
Copy link
Owner Author

lekeno commented Jun 12, 2018

Burned 0.8.3 for a hotfix so 0.8.4, hopefully.
@inorton I found it but it only had a few "connection forcibly closed" errors. I'll try to repro again and see if there is anything different.

@lekeno
Copy link
Owner Author

lekeno commented Jun 18, 2018

I see this error sometimes: "error in ensure_service: local variable 'program' referenced before assignment"

@inorton

@lekeno
Copy link
Owner Author

lekeno commented Jun 20, 2018

When closing EDMC, I'm also seeing this (probably minor):

error in send_raw: 'NoneType' object has no attribute 'send'
Traceback (most recent call last):
  File "plug.pyo", line 227, in notify_stop
  File "[...]\EDMarketConnector\plugins\EDMCOverlay\load.py", line 64, in plugin_stop
  File "[...]\EDMarketConnector\plugins\EDMCOverlay\edmcoverlay.py", line 109, in send_raw
AttributeError: 'NoneType' object has no attribute 'send'

@lekeno
Copy link
Owner Author

lekeno commented Jun 25, 2018

I'm still blocked on the weird issues above but more importantly the canonical EDMCOverlay should include the send_shape method since EDR relies on it.

@lekeno lekeno removed this from the 0.8.4 milestone Jun 25, 2018
@incryptx
Copy link

incryptx commented Nov 9, 2019

I'm getting "error in ensure_service" when EDMC tries to run EDMCOverlay, which exits without starting.

Running the latest version of EDR 1.00

Anyone know how to resolve this error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants