feat: return proper transaction receipt logs #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
==========================================
+ Coverage 95.17% 95.19% +0.01%
==========================================
Files 71 71
Lines 1058 1062 +4
Branches 197 198 +1
==========================================
+ Hits 1007 1011 +4
Misses 45 45
Partials 6 6
Continue to review full report at Codecov.
|
| transactionIndex: txPos, | ||
| blockNumber, | ||
| transactionHash: hash, | ||
| address: bufferToHex(Buffer.from(log[0])), |
There was a problem hiding this comment.
this will probably contain the sigHash of the transaction, not the address of the contract 🤔
There was a problem hiding this comment.
created an issue here: #331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #327