Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make MinGasPrice consensus param #163

Merged
merged 3 commits into from
Jan 31, 2019
Merged

make MinGasPrice consensus param #163

merged 3 commits into from
Jan 31, 2019

Conversation

johannbarbie
Copy link
Member

related to leapdao/leap-contracts#116
resolves #100

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #163 into master will decrease coverage by 0.34%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #163      +/-   ##
=========================================
- Coverage   94.15%   93.8%   -0.35%     
=========================================
  Files          54      55       +1     
  Lines         633     646      +13     
  Branches      114     116       +2     
=========================================
+ Hits          596     606      +10     
- Misses         33      36       +3     
  Partials        4       4
Impacted Files Coverage Δ
src/abis/exitHandler.js 100% <ø> (ø) ⬆️
src/tx/applyTx/checkMinGasPrice.js 100% <100%> (ø)
src/tx/applyTx/utils.js 98.38% <100%> (-1.62%) ⬇️
src/bridgeState.js 75% <50%> (-0.81%) ⬇️
src/tx/applyTx/checkDeposit.js 93.75% <0%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5545ad...15e6eec. Read the comment docs.

Copy link
Member

@sunify sunify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me 👌

@johannbarbie johannbarbie merged commit 24887bf into master Jan 31, 2019
@johannbarbie johannbarbie deleted the feature/minGasPrice branch January 31, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch minGasPrice from contract
2 participants