Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return errors when invalid transaction submitted #207

Open
johannbarbie opened this issue Mar 15, 2019 · 5 comments
Open

return errors when invalid transaction submitted #207

johannbarbie opened this issue Mar 15, 2019 · 5 comments

Comments

@johannbarbie
Copy link
Member

when using json rpc make sure to return error, if there is any.

@eshavkun
Copy link
Contributor

tendermint (called by sendTx.js helper) returns following in case of error in spending condition:

   { check_tx: { code: 2, log: '[object Object]' },
     deliver_tx: {},
     hash:
      'ED364A322874B9415B757BD09382838182DCF8AA1681F14C5E60602CFD9FB8AF',
     height: '0' } }```
The problem here is that log part is not an actual object but a string (saying `'[object Object]'`), needed to fix logging in https://github.com/leapdao/leap-node/blob/master/lotion/lib/abci-app.js#L46

@troggy
Copy link
Member

troggy commented Oct 26, 2019

not a bounty — not defined properly

@johannbarbie
Copy link
Member Author

not a bounty — not defined properly

@troggy
Copy link
Member

troggy commented Nov 23, 2019

why closing these?

@troggy troggy reopened this Nov 23, 2019
@johannbarbie johannbarbie removed bounty size-XS effort of ~3h labels Nov 23, 2019
@johannbarbie
Copy link
Member Author

johannbarbie commented Nov 23, 2019

ok, then i'll only remove the bounty labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants