Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Algebra/FreeAlgebra): support towers of algebras #6072

Closed
wants to merge 3 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jul 23, 2023

This provide Algebra R (FreeAlgebra A X) when Algebra R A; previously we only had Algebra R (FreeAlgebra R X).

This also fixes some diamonds that would arise as a result of this new instance by filling the zsmul and intCast fields of Module.addCommMonoidToAddCommGroup, Algebra.semiringToRing, and the nsmul and natCast fields of the Semiring instance.


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review awaiting-CI t-algebra Algebra (groups, rings, fields, etc) labels Jul 23, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 23, 2023
This provide `Algebra R (FreeAlgebra A X)` when `Algebra R A`.
This also fixes some diamonds that would arise as a result of this new instance.
@eric-wieser eric-wieser force-pushed the eric-wieser/tower-FreeAlgebra branch from e1494c8 to 331b33c Compare July 23, 2023 17:05
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 23, 2023
@ocfnash
Copy link
Contributor

ocfnash commented Jul 24, 2023

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 24, 2023
bors bot pushed a commit that referenced this pull request Jul 24, 2023
This provide `Algebra R (FreeAlgebra A X)` when `Algebra R A`; previously we only had `Algebra R (FreeAlgebra R X)`.

This also fixes some diamonds that would arise as a result of this new instance by filling the `zsmul` and `intCast` fields of `Module.addCommMonoidToAddCommGroup`, `Algebra.semiringToRing`, and the `nsmul` and `natCast` fields of the `Semiring` instance.
@bors
Copy link

bors bot commented Jul 24, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(Algebra/FreeAlgebra): support towers of algebras [Merged by Bors] - feat(Algebra/FreeAlgebra): support towers of algebras Jul 24, 2023
@bors bors bot closed this Jul 24, 2023
@bors bors bot deleted the eric-wieser/tower-FreeAlgebra branch July 24, 2023 10:30
fgdorais pushed a commit that referenced this pull request Jul 25, 2023
This provide `Algebra R (FreeAlgebra A X)` when `Algebra R A`; previously we only had `Algebra R (FreeAlgebra R X)`.

This also fixes some diamonds that would arise as a result of this new instance by filling the `zsmul` and `intCast` fields of `Module.addCommMonoidToAddCommGroup`, `Algebra.semiringToRing`, and the `nsmul` and `natCast` fields of the `Semiring` instance.
kim-em pushed a commit that referenced this pull request Aug 14, 2023
This provide `Algebra R (FreeAlgebra A X)` when `Algebra R A`; previously we only had `Algebra R (FreeAlgebra R X)`.

This also fixes some diamonds that would arise as a result of this new instance by filling the `zsmul` and `intCast` fields of `Module.addCommMonoidToAddCommGroup`, `Algebra.semiringToRing`, and the `nsmul` and `natCast` fields of the `Semiring` instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants