Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepare for removing @[simp] from Sum.forall and Sum.exists #18491

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kim-em
Copy link
Contributor

@kim-em kim-em commented Oct 31, 2024

I would like to remove @[simp] from Sum.forall and Sum.exists, per leanprover/lean4#5900.

The right hand sides of these lemmas are more complicated, and moreover they cause many problems with simp lemma confluence. (Confluence tool coming soon!)

This PR pre-emptively prepares Mathlib for this change. If we can't get it review in time I can just make these lemmas into simp lemmas globally in Mathlib.

Copy link

PR summary e87de0c017

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant