Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Order/Basic): add gcongr lemmas #18476

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(Order/Basic): add gcongr lemmas #18476

wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 31, 2024


Open in Gitpod

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Oct 31, 2024
Copy link

github-actions bot commented Oct 31, 2024

PR summary 63d7ddf060

Import changes exceeding 2%

% File
+4.42% Mathlib.Order.Basic

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Order.Basic 113 118 +5 (+4.42%)
Import changes for all files
Files Import difference
Mathlib.CategoryTheory.ClosedUnderIsomorphisms 4
12 files Mathlib.Order.Compare Mathlib.Algebra.Order.Group.Synonym Mathlib.Order.Max Mathlib.Order.ULift Mathlib.Algebra.Order.ZeroLEOne Mathlib.Algebra.Order.Group.Action.Synonym Mathlib.Order.Synonym Mathlib.Order.Basic Mathlib.Data.Nat.Cast.Synonym Mathlib.Algebra.Order.Sum Mathlib.Algebra.Order.Ring.Synonym Mathlib.Algebra.Order.GroupWithZero.Synonym
5

Declarations diff

++ ⟨_,

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@github-actions github-actions bot added the t-order Order theory label Oct 31, 2024
@urkud
Copy link
Member Author

urkud commented Oct 31, 2024

Should I put these lemmas elsewhere instead?

Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large-import Automatically added label for PRs with a significant increase in transitive imports maintainer-merge t-order Order theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants