Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(AlgebraicGeometry): define immersions #18154

Closed
wants to merge 4 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Oct 24, 2024


Open in Gitpod

Copy link

github-actions bot commented Oct 24, 2024

PR summary 6e583ac4ec

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.AlgebraicGeometry.Morphisms.Immersion 1738

Declarations diff

+ IsImmersion
+ Scheme.Hom.coborderRange
+ Scheme.Hom.isClosedEmbedding
+ Scheme.Hom.isLocallyClosed_range
+ Scheme.Hom.liftCoborder
+ Scheme.Hom.liftCoborder_ι
+ comp
+ comp_iff
+ instance (priority := 900) {X Y : Scheme} (f : X ⟶ Y) [IsClosedImmersion f] : IsImmersion f
+ instance (priority := 900) {X Y : Scheme} (f : X ⟶ Y) [IsOpenImmersion f] : IsImmersion f
+ instance : IsLocalAtTarget @IsImmersion := by
+ instance : MorphismProperty.IsMultiplicative @IsImmersion
+ instance [IsImmersion f] : IsClosedImmersion f.liftCoborder := by
+ instance [IsImmersion f] : IsDominant f.coborderRange.ι := by
+ isImmersion_eq_inf
+ isImmersion_iff_exists
+ of_comp
+ stableUnderBaseChange

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@github-actions github-actions bot added the t-algebraic-geometry Algebraic geometry label Oct 24, 2024
@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes label Oct 24, 2024
@joelriou
Copy link
Collaborator

Otherwise, it looks very good to me!

Co-authored-by: Joël Riou <[email protected]>
@erdOne erdOne removed the awaiting-author A reviewer has asked the author a question or requested changes label Oct 24, 2024
@joelriou
Copy link
Collaborator

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 24, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 24, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 24, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(AlgebraicGeometry): define immersions [Merged by Bors] - feat(AlgebraicGeometry): define immersions Oct 24, 2024
@mathlib-bors mathlib-bors bot closed this Oct 24, 2024
@mathlib-bors mathlib-bors bot deleted the erd1/immersion branch October 24, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebraic-geometry Algebraic geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants