Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: use newly introduced finset notation #17974

Closed
wants to merge 1 commit into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Oct 20, 2024

For s : Finset α, replace s.card with #s, s.filter p with {x ∈ s | p x}, ∑ x ∈ s.filter p, f x with ∑ x ∈ s with p x, f x. Rewrap lines around and open the Finset locale where necessary.


Open in Gitpod

@YaelDillies YaelDillies added the WIP Work in progress label Oct 20, 2024
Copy link

github-actions bot commented Oct 20, 2024

PR summary a9d5fc119e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

++-- card_Icc
++-- card_Ico
++-- card_Iio
++-- card_Ioc
++-- card_Ioo
++-- card_uIcc
++-- curryFinFinset
+-+- card_Iic
+-+- curryFinFinset_apply
+-+- curryFinFinset_apply_const
+-+- curryFinFinset_symm_apply
+-+- curryFinFinset_symm_apply_const
+-+- curryFinFinset_symm_apply_piecewise_const

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@YaelDillies YaelDillies removed the WIP Work in progress label Oct 21, 2024
@YaelDillies YaelDillies force-pushed the use_finset_notation branch 2 times, most recently from 3424d42 to 0de85b1 Compare October 22, 2024 11:44
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 22, 2024
For `s : Finset α`, replace `s.card` with `#s`, `s.filter p` with `{x ∈ s | p x}`, `∑ x ∈ s.filter p, f x` with `∑ x ∈ s with p x, f x`. Rewrap lines around and open the `Finset` locale where necessary.
@YaelDillies YaelDillies force-pushed the use_finset_notation branch 2 times, most recently from 8341372 to a9d5fc1 Compare October 22, 2024 18:05
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 22, 2024
@kim-em
Copy link
Contributor

kim-em commented Oct 23, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 23, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 23, 2024
For `s : Finset α`, replace `s.card` with `#s`, `s.filter p` with `{x ∈ s | p x}`, `∑ x ∈ s.filter p, f x` with `∑ x ∈ s with p x, f x`. Rewrap lines around and open the `Finset` locale where necessary.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: use newly introduced finset notation [Merged by Bors] - chore: use newly introduced finset notation Oct 23, 2024
@mathlib-bors mathlib-bors bot closed this Oct 23, 2024
@mathlib-bors mathlib-bors bot deleted the use_finset_notation branch October 23, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants