Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Algebra/Module): snake lemma #17948

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(Algebra/Module): snake lemma #17948

wants to merge 6 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Oct 19, 2024


Open in Gitpod

@erdOne erdOne added the t-algebra Algebra (groups, rings, fields, etc) label Oct 19, 2024
Copy link

github-actions bot commented Oct 19, 2024

PR summary 5f7372ae57

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Algebra.Module.SnakeLemma 873

Declarations diff

+ SnakeLemma.eq_of_eq
+ SnakeLemma.exact_δ'_left
+ SnakeLemma.exact_δ'_right
+ SnakeLemma.exact_δ_left
+ SnakeLemma.exact_δ_right
+ SnakeLemma.δ
+ SnakeLemma.δ'
+ SnakeLemma.δ'_eq
+ SnakeLemma.δ_aux
+ SnakeLemma.δ_eq

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Co-authored-by: Moritz Firsching <[email protected]>
Mathlib/Algebra/Module/SnakeLemma.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Module/SnakeLemma.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Module/SnakeLemma.lean Show resolved Hide resolved
@TwoFX TwoFX added the awaiting-author A reviewer has asked the author a question or requested changes label Oct 20, 2024
@erdOne erdOne removed the awaiting-author A reviewer has asked the author a question or requested changes label Oct 20, 2024
Comment on lines +100 to +102
Such that `f₂` is surjective with a (set-theoretic) section `ρ`, `g₁` is injective with a
(set-theoretic) retraction `π`,
then the map `π₁ ∘ ρ ∘ i₂ ∘ σ ∘ ι₃` is a linear map from `K₃` to `C₁`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Such that `f₂` is surjective with a (set-theoretic) section `ρ`, `g₁` is injective with a
(set-theoretic) retraction `π`,
then the map `π₁ ∘ ρ ∘ i₂ ∘ σ ∘ ι₃` is a linear map from `K₃` to `C₁`.
Such that `f₂` is surjective with a (set-theoretic) section `σ`, `g₁` is injective with a
(set-theoretic) retraction `ρ`,
then the map `π₁ ∘ ρ ∘ i₂ ∘ σ ∘ ι₃` is a linear map from `K₃` to `C₁`.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same typo appears in several other places in the file.

@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants