Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid Coe.coe in Data.Multiset.Functor #17942

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

This was ported incorrectly from mathlib3.


Open in Gitpod

This was ported incorrectly from mathlib3.
Copy link

PR summary ab08c7acc6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Oct 19, 2024
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Could also use Multiset.ofList which is a bit shorter, and what the notation amounts to.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 30, 2024

✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-data Data (lists, quotients, numbers, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants