Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(MeasureTheory): μ.comap Prod.swap = μ.map Prod.swap #17918

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(MeasureTheory): μ.comap Prod.swap = μ.map Prod.swap #17918

wants to merge 1 commit into from

Conversation

YaelDillies
Copy link
Collaborator

From PFR

Open in Gitpod

@YaelDillies YaelDillies added easy < 20s of review time. See the lifecycle page for guidelines. t-measure-probability Measure theory / Probability theory labels Oct 18, 2024
@github-actions GitHub Actions
Copy link

PR summary 99a786362a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ comap_swap

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

eric-wieser
eric-wieser approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

I don't have a feeling for whether this should have map or comap on the LHS.

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by eric-wieser.

jcommelin
jcommelin reviewed Oct 19, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Oct 19, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 19, 2024
@YaelDillies
feat(MeasureTheory): μ.comap Prod.swap = μ.map Prod.swap (#17918)
90c6be6 
From PFR
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 19, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(MeasureTheory): μ.comap Prod.swap = μ.map Prod.swap [Merged by Bors] - feat(MeasureTheory): μ.comap Prod.swap = μ.map Prod.swap Oct 19, 2024
@mathlib-bors mathlib-bors bot closed this Oct 19, 2024
@mathlib-bors mathlib-bors bot deleted the measure_comap_swap branch October 19, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge ready-to-merge This PR has been sent to bors. t-measure-probability Measure theory / Probability theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YaelDillies @eric-wieser @jcommelin @leanprover-community-mathlib4-bot