Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RingTheory/Localization/FractionRing): Lifting AlgEquivs to the field of fractions #17753

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat(RingTheory/Localization/FractionRing): Lifting AlgEquivs to the field of fractions #17753

wants to merge 7 commits into from
+75 −2

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Oct 15, 2024

This PR adds some API for lifting AlgEquivs to the field of fractions.

Open in Gitpod

@tb65536 tb65536 added t-algebra Algebra (groups, rings, fields, etc) awaiting-CI labels Oct 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

PR summary 48eb9e86fd

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ fieldEquivOfAlgEquiv
+ fieldEquivOfAlgEquivHom
+ fieldEquivOfAlgEquivHom_apply
+ fieldEquivOfAlgEquiv_algebraMap
+ fieldEquivOfAlgEquiv_refl
+ fieldEquivOfAlgEquiv_trans
+ fieldEquivOfRingEquiv_algebraMap

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@tb65536 tb65536 mentioned this pull request Oct 15, 2024
Open
8 tasks
@tb65536 tb65536 added the FLT part of the ongoing formalization of Fermat's Last Theorem label Oct 15, 2024
@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes label Oct 17, 2024
@tb65536 tb65536 added awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 17, 2024
@erdOne
Copy link
Member

erdOne commented Oct 31, 2024

Thanks!
maintainer merge

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by erdOne.

eric-wieser
eric-wieser reviewed Oct 31, 2024
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and also

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 31, 2024

✌️ tb65536 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

jcommelin
jcommelin reviewed Oct 31, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@jcommelin jcommelin jcommelin left review comments

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde left review comments

Assignees
No one assigned
Labels
delegated FLT part of the ongoing formalization of Fermat's Last Theorem maintainer-merge ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tb65536 @erdOne @eric-wieser @jcommelin @Ruben-VandeVelde @leanprover-community-mathlib4-bot