Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Topology/Category): make TopCat an abbrev #17641

Closed
wants to merge 3 commits into from
Closed

Conversation

Vierkantor
Copy link
Contributor

Like we did for the categories of rings in #11595 and #17612, turning TopCat into an abbrev allows us to get rid of some duplicate instances, and thereby reduce quite a few erws to simple rws.

There is one mild regression, see commit c051010: one _ had to be specified in slightly more detail before Lean could figure out what we mean. I believe the improvement in unification elsewhere weighs up to the regression, so I didn't check exactly what changed there.


Note that this will conflict somewhat with the fixes in #17638 so please do not bors them together. They should be fine to merge in either order, though.

Open in Gitpod

@Vierkantor Vierkantor added t-category-theory Category theory t-topology Topological spaces, uniform spaces, metric spaces, filters tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Oct 11, 2024
Copy link

PR summary 560253e688

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

- concreteCategory
- instance : CoeSort TopCat Type*

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@Vierkantor
Copy link
Contributor Author

Nevermind, looks like all these fixes are actually coming downstream from #17583, so they should be part of #17638 instead.

@Vierkantor Vierkantor closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-category-theory Category theory t-topology Topological spaces, uniform spaces, metric spaces, filters tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant