Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: bump lean4checker to v4.13.0-rc3 #17487

Closed
wants to merge 1 commit into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Oct 7, 2024

I think that there might be further issues with lake build, but this change seems at least needed.

I am hoping that #17486 tests this.


Open in Gitpod

Copy link

github-actions bot commented Oct 7, 2024

PR summary e6d7599794

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@github-actions github-actions bot added the CI Modifies the continuous integration / deployment setup label Oct 7, 2024
@adomani
Copy link
Collaborator Author

adomani commented Oct 7, 2024

@kim-em @jcommelin @bryangingechen

Pinging you, in case you are interested! 😄

@adomani
Copy link
Collaborator Author

adomani commented Oct 7, 2024

Could the issue also be a missing v4.13.0-rc3 tag?

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems innocuous and necessary. Thanks!
maintainer merge

Copy link

github-actions bot commented Oct 7, 2024

🚀 Pull request has been placed on the maintainer queue by grunweg.

@bryangingechen
Copy link
Contributor

The tag seems to be missing indeed per the failure in #17486 so I'm hesitant to merge this before that is done.

@bryangingechen
Copy link
Contributor

The v4.13.0-rc3 tag now exists. I'm not sure if we're still waiting on some fix but in case we're not:
bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 8, 2024

✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 8, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 8, 2024
I think that there might be further issues with `lake build`, but this change seems at least needed.

I am hoping that #17486 tests this.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 8, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Oct 8, 2024
I think that there might be further issues with `lake build`, but this change seems at least needed.

I am hoping that #17486 tests this.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 8, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: bump lean4checker to v4.13.0-rc3 [Merged by Bors] - chore: bump lean4checker to v4.13.0-rc3 Oct 8, 2024
@mathlib-bors mathlib-bors bot closed this Oct 8, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/bump_lean4checker_to_13_rc3 branch October 8, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Modifies the continuous integration / deployment setup delegated maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants