-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: remove ported tactic from Mathport syntax #14385
Conversation
PR summary a6570e0d20Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! move_add and move_mul look good to me - but wasn't move_op
renamed to move_oper
?
awaiting-author |
It is called |
Good question! I don't know if there's a way to report that - if there isn't, I won't object to removing this as-is. |
Should perhaps mathport be tweaked, to emit |
I have not looked at mathport, but the only references to I am going to re-label as awaiting-review, and maybe someone else can give an opinion as well! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maintainer merge
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
bors merge |
`move_add`, `move_mul` and `move_oper` are all available in `Mathlib`.
Pull request successfully merged into master. Build succeeded: |
move_add
,move_mul
andmove_oper
are all available inMathlib
.