Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: remove ported tactic from Mathport syntax #14385

Closed
wants to merge 1 commit into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Jul 3, 2024

move_add, move_mul and move_oper are all available in Mathlib.


Open in Gitpod

Copy link

github-actions bot commented Jul 3, 2024

PR summary a6570e0d20

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! move_add and move_mul look good to me - but wasn't move_op renamed to move_oper?

@grunweg
Copy link
Collaborator

grunweg commented Jul 3, 2024

awaiting-author

@github-actions github-actions bot added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jul 3, 2024
@adomani
Copy link
Collaborator Author

adomani commented Jul 3, 2024

It is called move_oper now, yes, but where should I report that?

@grunweg
Copy link
Collaborator

grunweg commented Jul 3, 2024

Good question! I don't know if there's a way to report that - if there isn't, I won't object to removing this as-is.

@grunweg
Copy link
Collaborator

grunweg commented Jul 3, 2024

Should perhaps mathport be tweaked, to emit move_oper instead of move_op?

@adomani
Copy link
Collaborator Author

adomani commented Jul 3, 2024

I have not looked at mathport, but the only references to move_op that I could find in mathlib are the ones that I removed. The tactic was almost never used anyway, and probably really never in its move_op/move_oper form, so I do not think that it is a big deal if mathport converts it incorrectly.

I am going to re-label as awaiting-review, and maybe someone else can give an opinion as well!

@adomani adomani added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 3, 2024
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Copy link

github-actions bot commented Jul 3, 2024

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@kim-em
Copy link
Contributor

kim-em commented Jul 3, 2024

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 3, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 3, 2024
`move_add`, `move_mul` and `move_oper` are all available in `Mathlib`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 3, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove ported tactic from Mathport syntax [Merged by Bors] - chore: remove ported tactic from Mathport syntax Jul 3, 2024
@mathlib-bors mathlib-bors bot closed this Jul 3, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/move_add_ported branch July 3, 2024 22:44
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants