-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Order.RelIso): remove some porting notes #12786
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!bench |
Here are the benchmark results for commit 33cfb3b. |
YaelDillies
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maintainer merge
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
bors merge |
github-actions
bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
labels
May 9, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 9, 2024
We get the `CoeFun` through `FunLike` which seems the current idiom. The changes are reducibly defeq to the porting remnants.
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
chore(Order.RelIso): remove some porting notes
[Merged by Bors] - chore(Order.RelIso): remove some porting notes
May 10, 2024
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
We get the `CoeFun` through `FunLike` which seems the current idiom. The changes are reducibly defeq to the porting remnants.
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
We get the `CoeFun` through `FunLike` which seems the current idiom. The changes are reducibly defeq to the porting remnants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get the
CoeFun
throughFunLike
which seems the current idiom. The changes are reducibly defeq to the porting remnants.