Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Order.RelIso): remove some porting notes #12786

Closed
wants to merge 2 commits into from

Conversation

mattrobball
Copy link
Collaborator

We get the CoeFun through FunLike which seems the current idiom. The changes are reducibly defeq to the porting remnants.


Open in Gitpod

@mattrobball
Copy link
Collaborator Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 33cfb3b.
There were no significant changes against commit 690d741.

Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Copy link

github-actions bot commented May 9, 2024

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels May 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request May 9, 2024
We get the `CoeFun` through `FunLike` which seems the current idiom. The changes are reducibly defeq to the porting remnants.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented May 10, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Order.RelIso): remove some porting notes [Merged by Bors] - chore(Order.RelIso): remove some porting notes May 10, 2024
@mathlib-bors mathlib-bors bot closed this May 10, 2024
@mathlib-bors mathlib-bors bot deleted the mrb/clean_up_order_reliso branch May 10, 2024 00:14
apnelson1 pushed a commit that referenced this pull request May 12, 2024
We get the `CoeFun` through `FunLike` which seems the current idiom. The changes are reducibly defeq to the porting remnants.
callesonne pushed a commit that referenced this pull request May 16, 2024
We get the `CoeFun` through `FunLike` which seems the current idiom. The changes are reducibly defeq to the porting remnants.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants