Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: have to let #12180

Closed
wants to merge 2 commits into from
Closed

test: have to let #12180

wants to merge 2 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Apr 16, 2024

Test the performance effect of replacing non-Prop-valued haves to lets.

See #12157 for the PR with the linter.


Open in Gitpod

@adomani

This comment was marked as outdated.

@adomani
Copy link
Collaborator Author

adomani commented Apr 16, 2024

!bench

@leanprover-bot

This comment was marked as outdated.

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit ee8ce85.
There were no significant changes against commit f47773f.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 17, 2024
@adomani adomani closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants