Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependent PRs are not reported correctly #12

Open
eric-wieser opened this issue Feb 20, 2023 · 3 comments
Open

dependent PRs are not reported correctly #12

eric-wieser opened this issue Feb 20, 2023 · 3 comments

Comments

@eric-wieser
Copy link
Member

When dependent PRs are made, then the heuristic of "look at all the changed files and attach them to this PR" doesn't work, because a file in a PR will also be attached to all its dependencies. This line in the make_port_status.py script then just picks the first one, essentially at random:

https://github.com/leanprover-community/mathlib4/blob/7e974fd3806866272e9f6d9e44fa04c210a21f87/scripts/make_port_status.py#L164

This also means that some PRs won't appear on the dashboard at all, because their association gets overwritten by a PR that depends on them.

cc @rwbarton, @jcommelin; reported by @mattrobball who noted leanprover-community/mathlib4#2332 didn't appear on the dashboard at all.

@eric-wieser
Copy link
Member Author

The fix for this will likely need to live in the mathlib4 repo.

@mattrobball
Copy link

This PR is merged now so perhaps the behavior will change?

@mattrobball
Copy link

It now shows up as ported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants