Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple reports #22

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Multiple reports #22

wants to merge 3 commits into from

Conversation

dannylewis-sheffield
Copy link
Contributor

Added the option to allow multiple reports.

Sample behat.yml:

        format:
            - html
            - clover
        output:
            html:
                target: public/coverage-behat
            clover:
                target: clover/behat.xml

I've left the original report option as is, so no breaking changes.

@ek9
Copy link
Member

ek9 commented Mar 17, 2018

Hi,

Thank you for the PR. There are a few problems:

  1. The code update is very messy in ReportService.php. The nested if/then/else is unclean and there should be a more clean way to handle this.
  2. The code style is very different from the current coding style that project is using. I have made Add conding style guide and checker #25 so we have code style checks as part of the Travis.
  3. The travis build for your update contains errors (the tests fail). The tests must be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants